Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: 3DS; SWORD25, TITANIC: Resolve leftover signedness issues #3137

Merged
merged 3 commits into from Jul 8, 2021

Conversation

@BallM4788
Copy link
Contributor

@BallM4788 BallM4788 commented Jul 8, 2021

Resolves leftover signedness issues to conform to baccbed.

@digitall
Copy link
Member

@digitall digitall commented Jul 8, 2021

@BallM4788 : Thanks for these fixes. Apart from fixing the conflict, can you split these into a commit per engine and 3DS backend please? This makes future bisection much easier as the changes are not really directly related.

@BallM4788 BallM4788 force-pushed the BallM4788:master branch from 994fe5d to 86bdfc2 Jul 8, 2021
BallM4788 added 3 commits Jul 8, 2021
Resolves leftover signedness issues to conform to baccbed.
Resolves leftover signedness issues to conform to baccbed.
Resolves leftover signedness issues to conform to baccbed.
@BallM4788 BallM4788 force-pushed the BallM4788:master branch from d71bb41 to e156c9a Jul 8, 2021
@BallM4788 BallM4788 changed the title BACKENDS:3DS;MOHAWK,SWORD25,TITANIC: Resolve leftover signedness issues BACKENDS: 3DS; SWORD25, TITANIC: Resolve leftover signedness issues Jul 8, 2021
@BallM4788
Copy link
Contributor Author

@BallM4788 BallM4788 commented Jul 8, 2021

@digitall there, that should do it. @dreammaster has fixed the MOHAWK instances, so I removed them from this pull.

@digitall
Copy link
Member

@digitall digitall commented Jul 8, 2021

@BallM4788 : Looks good now. Will merge as-is. Thanks again for this work.

@digitall digitall merged commit abf9788 into scummvm:master Jul 8, 2021
1 check passed
1 check passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants