Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Fix some compiler warnings #3140

Merged
merged 3 commits into from Jul 8, 2021

Conversation

@mparnaudeau
Copy link
Contributor

@mparnaudeau mparnaudeau commented Jul 8, 2021

  • Fix -Wsign-compare in engines/titanic
  • Fix -Wformat-truncation in engines/queen
  • Fix -Wunused-variable in engines/trecision
@digitall
Copy link
Member

@digitall digitall commented Jul 8, 2021

@mparnaudeau : Thanks for these fixes. I was already looking at these, but you have pretty much the same changes I was intending. One point, can you split these into a commit per engine please? This makes future bisection much easier as the changes are not really related.

@mparnaudeau
Copy link
Contributor Author

@mparnaudeau mparnaudeau commented Jul 8, 2021

@digitall : You're right, I'm about to do that.

@mparnaudeau mparnaudeau force-pushed the mparnaudeau:engines_fix_compiler_warnings branch from 98af93a to a9d1da6 Jul 8, 2021
@digitall
Copy link
Member

@digitall digitall commented Jul 8, 2021

@mparnaudeau : Thanks. Looks good. Will merge as-is.

@digitall digitall merged commit 4b182da into scummvm:master Jul 8, 2021
1 check passed
1 check passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants