Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVENTRECORDER: added new event for OSystem::getTimeAndDate #3141

Merged
merged 1 commit into from Jul 9, 2021

Conversation

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented Jul 9, 2021

OSystem::getTimeAndDate() is used in e.g. SCI and SCUMM - this wires it up to the event recorder.

Introducing a new event and changed the getTimeAndDate method

@mgerhardy mgerhardy requested a review from sluicebox Jul 9, 2021
@sluicebox
Copy link
Member

@sluicebox sluicebox commented Jul 9, 2021

Wow, such quick turn around from a discord comment to a feature! Thanks!

I tested this with the debugger on a few SCI games and in Codename Iceman there's a part that prints the current date; I changed my clock and recorded and changed it back and the record-date correctly displayed on playback.

I now see that in SCI we call OSystem::getTimeAndDate() in situations where we don't use the result in kGetTime. I'll change that after this is merged, since it's a code-path that gets called a lot in some games, and that will cut down on the number of these new events that get generated.

@mgerhardy mgerhardy merged commit a0c237f into scummvm:master Jul 9, 2021
1 check passed
1 check passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants