Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYMBIAN: Final batch to make Symbian port self-builded. #3142

Merged
merged 4 commits into from Jul 12, 2021
Merged

SYMBIAN: Final batch to make Symbian port self-builded. #3142

merged 4 commits into from Jul 12, 2021

Conversation

@fedor4ever
Copy link
Contributor

@fedor4ever fedor4ever commented Jul 9, 2021

This is final batch to make Symbian port self-builded. I hope.

Add missed library dependency in build_app_config.mmh.
Resolve linker errors by compiling certain source files with exe. This happens because these files should depends from specific engines.
Added generator for installer builder.
Added source patcher. It make abld build system happy if these patches break other ports and therefore can't accepted. Currently fixes "..." in macros arguments.
Delete obsolete files.

fedor4ever added 2 commits Jul 7, 2021
Add missed library dependency.
Resolve linker errors compiling certain files with exe
Added generator for installer builder
Added source patcher. It make abld build system happy if these patches break other ports and therefore can't accepted. Currently fixes "..." in macros arguments.
Delete obsolete files.
@sev-
Copy link
Member

@sev- sev- commented Jul 9, 2021

The commit log messages are not conformant with our guidelines

@fedor4ever fedor4ever changed the title Symbian fix SYMBIAN: Final batch to make Symbian port self-builded. Jul 9, 2021
Allow build older version with current symbian_builder module in case regression.
Set verbose option in installer builder instead error-checking.
Fix ugly 'crcrlf' line endings.
@fedor4ever
Copy link
Contributor Author

@fedor4ever fedor4ever commented Jul 11, 2021

Commit log messages are conformant now.

@sev-
Copy link
Member

@sev- sev- commented Jul 12, 2021

Thank you

@sev- sev- merged commit 1783836 into scummvm:master Jul 12, 2021
7 of 8 checks passed
7 of 8 checks passed
@github-actions
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi...
Details
@github-actions
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi, ...
Details
@github-actions
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fri...
Details
@github-actions
Xcode (macosx, -scheme ScummVM-macOS, --disable-nasm --enable-faad --enable-mpeg2, a52dec faad2 f...
Details
@github-actions
Xcode (ios7, -scheme ScummVM-iOS CODE_SIGN_IDENTITY="" CODE_SIGNING_ALLOWED=NO, --disable-nasm --...
Details
@github-actions
Ubuntu (ubuntu-latest, sdl2-config, --enable-c++11, libsdl2-dev libsdl2-net-dev liba52-dev libjpe...
Details
@github-actions
Ubuntu (ubuntu-18.04, sdl-config, --disable-c++11, libsdl1.2-dev libsdl-net1.2-dev liba52-dev lib...
Details
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants