Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AGS: Pointers should not be casted to long #3148

Merged
merged 2 commits into from Jul 12, 2021
Merged

Conversation

@aviloria
Copy link
Contributor

@aviloria aviloria commented Jul 11, 2021

New string arithmetic is using pointers diff casted to long...
Trying to avoid C++11 features, the best option is to cast them to intptr_t instead of long

aviloria added 2 commits Jul 11, 2021
New string arithmetic is using pointers diff casted to long...
Trying to avoid C++11 features, the best option is to cast them to intptr_t instead of long
New string arithmetic is using pointers diff casted to long...
Trying to avoid C++11 features, the best option is to cast them to intptr_t instead of long
@aviloria
Copy link
Contributor Author

@aviloria aviloria commented Jul 11, 2021

These changes should fix scummvm compilation

@digitall digitall requested a review from dreammaster Jul 11, 2021
@digitall
Copy link
Member

@digitall digitall commented Jul 11, 2021

@aviloria : Thanks for your contribution. Looks reasonable... Will just await a quick review from @dreammaster who is working on this engine.

@dreammaster
Copy link
Member

@dreammaster dreammaster commented Jul 12, 2021

Looks good to me

@dreammaster dreammaster merged commit 09ed759 into scummvm:master Jul 12, 2021
1 check passed
1 check passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants