Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GOB: Avoid an off by one #3152

Merged
merged 1 commit into from Jul 14, 2021
Merged

GOB: Avoid an off by one #3152

merged 1 commit into from Jul 14, 2021

Conversation

@lu-zero
Copy link
Contributor

@lu-zero lu-zero commented Jul 13, 2021

Lost in Time (English floppy version but CD version might be affected as well) garbles colours during some clips playback otherwise.

The easiest way to reproduce is in manor section of the game: when it starts, just click the horse at the gate or any object in the tractor. A video will play that will also garble one colour in the picture to red (the same happens in other parts of manor section when small clips play).

I believe it's caused by an off-by-one error in palette copy (e.g. for PORTAL04.IMD colours 16-127 are copied).

This patch seems to fix it.

Lost in Time (English floppy version but CD version might be affected as well)
garbles colours during some clips playback otherwise.
@digitall
Copy link
Member

@digitall digitall commented Jul 14, 2021

Can replicate the issue with the horse video. Will merge for testing...

@digitall digitall merged commit 58d32ad into scummvm:master Jul 14, 2021
1 check passed
1 check passed
@codacy-production
Codacy Static Code Analysis Codacy Static Code Analysis
Details
@digitall
Copy link
Member

@digitall digitall commented Jul 15, 2021

@lu-zero : Thanks for your code contribution. As expected, this fixes the issue and probably other minor palette bugs with video playback in GOB games.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants