Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLADERUNNER: fix encodings for save descriptions #3153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@athrxx
Copy link
Member

@athrxx athrxx commented Jul 13, 2021

If you type save names like e. g. "äöüß" in the GMM this will now show up correctly in the ingame save/load dialogs.

You still cannot type these characters ingame due to the current implementation of UIInputBox::charIsValid(). I don't know the purpose of the function. If I comment out everything and simply return true it works fine (I can enter all these special characters). So it is not a limitation of the font, even though I have the English version. If the only reason for charIsValid() was the wrong encoding it might make sense to limit or even remove it.

athrxx added 2 commits Jul 13, 2021
If you type save names like e. g. "äöüß" in the GMM this will now show up correctly in the ingame save/load dialogs.

You still cannot type these characters ingame due to the current implementation of UIInputBox::charIsValid(char kc). I don't know why. If I comment out this function and simply return true it works just fine for me. So it is not a limitation of the font (although I am playing the English version).

Still, I haven't changed that behavior, since I am not familiar with the engine...If the only reason for charIsValid() was the wrong encoding it might make sense to limit or even remove it.
@sev- sev- requested a review from antoniou79 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant