Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Fix encoding for Hebrew dialogs #3161

Merged
merged 2 commits into from Jul 21, 2021
Merged

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Jul 16, 2021

Like Pause dialog.

@orgads
Copy link
Contributor Author

@orgads orgads commented Jul 16, 2021

Before:
image
After:
image

@orgads
Copy link
Contributor Author

@orgads orgads commented Jul 16, 2021

Some games use DOS862 encoding. Will push a fixed revision soon.

@orgads orgads force-pushed the orgads:hebrew-dialogs branch 2 times, most recently from e85a533 to 7cc06c6 Jul 16, 2021
engines/scumm/string.cpp Outdated Show resolved Hide resolved
@orgads orgads force-pushed the orgads:hebrew-dialogs branch 3 times, most recently from 415e1a5 to 4b644dd Jul 18, 2021
@orgads
Copy link
Contributor Author

@orgads orgads commented Jul 20, 2021

ping?

engines/scumm/string.cpp Outdated Show resolved Hide resolved
engines/scumm/string.cpp Outdated Show resolved Hide resolved
engines/scumm/string.cpp Outdated Show resolved Hide resolved
engines/scumm/string.cpp Outdated Show resolved Hide resolved
@orgads orgads force-pushed the orgads:hebrew-dialogs branch from 9167bc1 to 6611307 Jul 21, 2021
@bluegr
Copy link
Member

@bluegr bluegr commented Jul 21, 2021

Overall, this looks good now, thanks! Nice work, merging

@bluegr bluegr merged commit 2602d0f into scummvm:master Jul 21, 2021
7 checks passed
7 checks passed
@github-actions
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi...
Details
@github-actions
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fribidi, ...
Details
@github-actions
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fri...
Details
@github-actions
Xcode (macosx, -scheme ScummVM-macOS, --disable-nasm --enable-faad --enable-mpeg2, a52dec faad2 f...
Details
@github-actions
Xcode (ios7, -scheme ScummVM-iOS CODE_SIGN_IDENTITY="" CODE_SIGNING_ALLOWED=NO, --disable-nasm --...
Details
@github-actions
Ubuntu (ubuntu-latest, sdl2-config, --enable-c++11, libsdl2-dev libsdl2-net-dev liba52-dev libjpe...
Details
@github-actions
Ubuntu (ubuntu-18.04, sdl-config, --disable-c++11, libsdl1.2-dev libsdl-net1.2-dev liba52-dev lib...
Details
@orgads orgads deleted the orgads:hebrew-dialogs branch Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants