COMMON: Change TransMan builtin language to "en" instead of "C" #3165
The change in this pull request change
This seems more logical to me and allows to simplify some code (which is also included in this pull request).
#ifdef USE_TRANSLATION Common::String cl = TransMan.getCurrentLanguage(); #else Common::String cl("en"); #endif
makes more sense than
#ifdef USE_TRANSLATION Common::String cl = TransMan.getCurrentLanguage(); #else Common::String cl("C"); #endif
We can remove the following in various places
if (currentLanguage == "C") currentLanguage = "en";
If we ever want to use a custom font for English in a theme, it makes more sense to write
If we want to provide an English translation that differs from the hardcoded strings in the source code, I would expect it to be something like "en_GB" or "en_ZA" for example. So that would still be possible with this change.
Also current config files are still correctly loaded as
I am not sure if I missed something and if there was a good reason to return "C", which is why I created this pull request. If you see a possible issue with this change, please speak up.
As indicated by SupSuper on Discord, the "C" almost certainly comes from the "C" locale. But
I just saw that
You mean if
But if we change the documentation of