Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SYMBIAN: Minor fixes for comments and code. #3166

Closed
wants to merge 64 commits into from
Closed

SYMBIAN: Minor fixes for comments and code. #3166

wants to merge 64 commits into from

Conversation

@huhungahuru
Copy link

@huhungahuru huhungahuru commented Jul 17, 2021

No description provided.

huhungahuru added 30 commits Jul 17, 2021
Correcting the code format according to the guidelines.
- Line 48 (const HardwareInput& x, const HardwareInput& y) is replaced by (const HardwareInput &x, const HardwareInput &y).
- Line 57 (const HardwareInput& x) is replaced by (const HardwareInput &x).

Example of another case: #3157
huhungahuru added 28 commits Jul 17, 2021
c\resource\help was changed to !\resource\help, to allow installation in any memory of the phone.

- This line of code is valid or not! 
bld freeze lib cleanlib final resource savespace releasables :
Correcting the code format according to the guidelines.
- Line 118 (TDes& aDataFolder) is replaced by (TDes &aDataFolder).
Correcting the code format according to the guidelines.
- Line 46 (TDes& aDataFolder) is replaced by (TDes &aDataFolder).
Added (printf("%s\n", "Debug: STDOUT and STDERR redirected to text files.");)
@digitall
Copy link
Member

@digitall digitall commented Jul 18, 2021

@huhungahuru: It looks like you are still working on these changes. Once you are ready for review and merge, please resubmit your branch as a Pull Request. You should also look at how feature branches work and how to use rebase to squash and avoid merge commits.

@digitall digitall closed this Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants