Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Add Spanish version of the MI1 Lemonhead patch #3297

Merged
merged 1 commit into from Sep 2, 2021

Conversation

@eriktorbjorn
Copy link
Member

@eriktorbjorn eriktorbjorn commented Aug 21, 2021

TEST THIS BEFORE MERGING!!!

This adds the missing Lemonhead lines to the Spanish version of The Secret of Monkey Island.

I don't have this version of the game myself, so the texts are based on a YouTube playthrough and the rest is based on walking timofonic through the steps of locating the script to patch. Unfortunately, at the moment there is no one (including timofonic) who has been able to test it. I'm submitting the pull request so that it won't get lost before the next release, but at the moment it's not ready for merging.

In addition to the script patch, I'm not certain of the character encoding. The current strings look correct if I insert them in the English version, though.

I don't have this version of the game myself, so it's based on a YouTube
playthrough and walking through the process of extracting the necessary
data with timofonic. It has not been properly tested, though the
messages do look correct if I insert them into the English version.
@ghoost82
Copy link
Contributor

@ghoost82 ghoost82 commented Aug 21, 2021

@eriktorbjorn I have tested the patch with the version that comes with the multilanguage CD-ROM of Monkey Island. The missing lines where shown.

@bluegr
Copy link
Member

@bluegr bluegr commented Aug 22, 2021

@eriktorbjorn So, this should be OK to merge then, based on the feedback provided?

@eriktorbjorn
Copy link
Member Author

@eriktorbjorn eriktorbjorn commented Aug 23, 2021

@bluegr I guess so (assuming the missing lines are correct), though timofonic said he'd probably be able to test it today as well.

@eriktorbjorn
Copy link
Member Author

@eriktorbjorn eriktorbjorn commented Aug 25, 2021

@bluegr Turns out I was too optimistic when I thought he'd be able to test it on Monday. He said he would have a laptop on Monday, and then he would install Linux on it. After that, I haven't heard anything.

@eriktorbjorn
Copy link
Member Author

@eriktorbjorn eriktorbjorn commented Sep 2, 2021

Seen on #scummvm:

(10:39:16) grogbot: @eriktorbjorn can confirm message matches the one dumped from Spanish VGA ([009A] (14) print(3,[Text("Oooh, qu\x82 bonito." + wait() + "Simple. Como uno de los m\xA1os." + wait() + "Y peque\xA4o, como los m\xA1os.")]);)

So that should confirm both that the message is shown, and that it's correct.

@sev-
Copy link
Member

@sev- sev- commented Sep 2, 2021

Thanks, merging and backporting

@sev- sev- merged commit 7aadf63 into scummvm:master Sep 2, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants