Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Avoid using static objects with destructors #3314

Merged
merged 4 commits into from Sep 2, 2021

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Aug 26, 2021

This is one of the issues causing Trac #11712.

@bluegr
Copy link
Member

@bluegr bluegr commented Aug 26, 2021

Nice! Have these changes been tested?

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Aug 26, 2021

Nice! Have these changes been tested?

cine, illusions and supernova have been tested briefly with the DS port, while lab has not been tested.

@bluegr
Copy link
Member

@bluegr bluegr commented Sep 2, 2021

I've tested the changes in lab and everything is working as expected.

Thanks again for your work! This is a straightforward change towards the right direction.

Merging

@bluegr bluegr merged commit c731d6c into scummvm:master Sep 2, 2021
8 checks passed
8 checks passed
@github-actions
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --enable-discord, curl discord-rpc...
Details
@github-actions
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --enable-discord, curl discord-rpc f...
Details
@github-actions
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fri...
Details
@github-actions
Xcode (macosx, -scheme ScummVM-macOS, --disable-nasm --enable-faad --enable-mpeg2, a52dec faad2 f...
Details
@github-actions
Xcode (ios7, -scheme ScummVM-iOS CODE_SIGN_IDENTITY="" CODE_SIGNING_ALLOWED=NO, --disable-nasm --...
Details
@github-actions
Ubuntu (ubuntu-latest, sdl2-config, --enable-c++11, libsdl2-dev libsdl2-net-dev liba52-dev libjpe...
Details
@github-actions
Ubuntu (ubuntu-18.04, sdl-config, --disable-c++11, libsdl1.2-dev libsdl-net1.2-dev liba52-dev lib...
Details
@codacy-production
Codacy Static Code Analysis A positive pull request.
Details
@ccawley2011 ccawley2011 deleted the ccawley2011:cine-static-object branch Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants