Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BACKENDS: Allow activating the system virtual keyboard using the keymapper #3316

Merged
merged 2 commits into from Nov 1, 2021

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Aug 27, 2021

No description provided.

@sev-
Copy link
Member

@sev- sev- commented Aug 30, 2021

I still find these changed quite risky and touching all ports. Why not defining ENABLE_VKEYBD for the port but then show the system keyboard when it is triggered, just as Android and iOS ports are doing?

Or, alternatively, introduce port-specific Action "System Keyboard" and let the keymapper handle it?

These changes would trigger VK-related events at different code paths, like that long press, or have some events eaten but having no effect when Vk is not enabled like on most of the desktops.

Loading

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Aug 30, 2021

Defining ENABLE_VKEYBD will enable the built-in virtual keyboard which will increase memory usage significantly on the DS, which is why a custom virtual keyboard is used in the first place. The removal of those specific ifdefs shouldn't interfere with existing platforms, since the keymapper action is not added when there isn't a virtual keyboard, and middle mouse events shouldn't be affected by the additional no-op event. I can drop the GPH, Dingux and SamsungTV changes if necessary, though.

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 1, 2021

Okay, merging this.

Loading

@sev- sev- merged commit dd1bf34 into scummvm:master Nov 1, 2021
7 checks passed
Loading
@ccawley2011 ccawley2011 deleted the system-virtual-keyboard branch Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants