Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual manual download #3319

Merged
merged 4 commits into from Sep 4, 2021
Merged

Manual manual download #3319

merged 4 commits into from Sep 4, 2021

Conversation

@criezy
Copy link
Member

@criezy criezy commented Aug 28, 2021

Fixes trying to copy the user manual pdf file when it is not present.
This does so by checking if the file is present before adding it to DIST_FILES_DOCS.

This is an alternative to pull request #3317 that instead automatically downloads the manual if not present (or at least try to do so). Since that pull request had already been merged, this pull request includes reverting the commits it contained.

I am not sure which approach is best, which is why I am proposing this as a pull request. With the changes here, if we want to bundle the user manual, we need to run manually make manual first. But in the case of a release, the file could be included in the release tarball.

One issue with the automatic download is that it requires an internet access. Without one trying to do make bundle or make install will fail.

criezy added 4 commits Aug 28, 2021
Using quotes does not work on all platforms.
This fixes build errors, for example when running make bundle on
macOS, or make install on Linux, if make manual has not been run
previously.
@criezy criezy changed the title Manual manual Manual manual download Aug 28, 2021
@sev-
Copy link
Member

@sev- sev- commented Sep 4, 2021

Well, I am now merging this and backporting. The previous automatic approach was problematic in at least two scenarios:

  • When the host has no internet connection, like Raspberry Pi
  • When the host does not have curl, like Amiga

@sev- sev- merged commit 7db6a06 into scummvm:master Sep 4, 2021
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants