Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONFIGURE: Drop u flag for ar #3320

Merged
merged 1 commit into from Sep 2, 2021
Merged

CONFIGURE: Drop u flag for ar #3320

merged 1 commit into from Sep 2, 2021

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Aug 28, 2021

On replace mode (r), u tells ar to replace object files only if the source
file is newer than the one in the archive.

When binutils is configured with --enable-deterministic-archives, the
default mode for ar is D (deterministic), which means that all the files
are stored with zero for UID, GID and timestamp. This means that ar has no
way to tell if the archived file is older than the source file, so it just
archives all the input files and issues the following warning:

`u' modifier ignored since `D' is the default (see `U')

Fix by dropping this flag. The performance gain is negligible anyway.

On replace mode (r), u tells ar to replace object files only if the source
file is newer than the one in the archive.

When binutils is configured with --enable-deterministic-archives, the
default mode for ar is D (deterministic), which means that all the files
are stored with zero for UID, GID and timestamp. This means that ar has no
way to tell if the archived file is older than the source file, so it just
archives all the input files and issues the following warning:
`u' modifier ignored since `D' is the default (see `U')

Fix by dropping this flag. The performance gain is negligible anyway.
@lotharsm
Copy link
Member

@lotharsm lotharsm commented Aug 28, 2021

+1 for this. I already dropped the u flag for the Win32/MinGW builds a while ago - good idea to do this globally.

@orgads orgads changed the base branch from branch-2-3 to master Aug 28, 2021
@lotharsm
Copy link
Member

@lotharsm lotharsm commented Aug 29, 2021

I wonder if there might be a reason why specific builds specifically ask for cru? Maybe it is better to just change the default value here and leave modifying the port-specific settings to the porters instead.

@orgads
Copy link
Contributor Author

@orgads orgads commented Aug 29, 2021

My guess is copy/paste, either from other builds or other projects.

@lotharsm
Copy link
Member

@lotharsm lotharsm commented Sep 2, 2021

Thank you for this patch, @orgads! Merging now - let's see if buildbot complains ;-)

@lotharsm lotharsm merged commit 0b90777 into scummvm:master Sep 2, 2021
7 checks passed
@orgads orgads deleted the ar-no-u branch Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants