Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BURIED: Clear the live text window when moving, as advertised (bug 12887) #3339

Merged
merged 1 commit into from Sep 8, 2021

Conversation

@eriktorbjorn
Copy link
Member

@eriktorbjorn eriktorbjorn commented Sep 3, 2021

The comment says it will clear the live text window, but instead disabled the navigation arrows (I think), which it then does again right aftewards. A cut and paste error, perhaps? Anyway, I hope this produces the correct behavior as described in https://bugs.scummvm.org/ticket/12887

I also noticed that there are a number of updateLiveText("") calls (to clear the text), even though an empty string is the default value for it. But I didn't bother cleaning that up.

…887)

The comment says it will clear the live text window, but instead
disabled the navigation arrows (I think), which it then does again right
aftewards. A cut and paste error, perhaps?
@Thunderforge
Copy link
Contributor

@Thunderforge Thunderforge commented Sep 7, 2021

The live text now clears when moving forward, just like in the original engine. I tried it under several different situations and they all seem to be fixed now.

@sev-
Copy link
Member

@sev- sev- commented Sep 8, 2021

Thank you!

@sev- sev- merged commit 0efdcb9 into scummvm:master Sep 8, 2021
7 checks passed
7 checks passed
@github-actions
Windows (win32, x86-windows, x86, --enable-faad --enable-mpeg2 --enable-discord, curl discord-rpc...
Details
@github-actions
Windows (x64, x64, x64-windows, --enable-faad --enable-mpeg2 --enable-discord, curl discord-rpc f...
Details
@github-actions
Windows (arm64, arm64, arm64-windows, --enable-faad --enable-mpeg2 --enable-discord --disable-fri...
Details
@github-actions
Xcode (macosx, -scheme ScummVM-macOS, --disable-nasm --enable-faad --enable-mpeg2, a52dec faad2 f...
Details
@github-actions
Xcode (ios7, -scheme ScummVM-iOS CODE_SIGN_IDENTITY="" CODE_SIGNING_ALLOWED=NO, --disable-nasm --...
Details
@github-actions
Ubuntu (ubuntu-latest, sdl2-config, --enable-c++11, libsdl2-dev libsdl2-net-dev liba52-dev libjpe...
Details
@github-actions
Ubuntu (ubuntu-18.04, sdl-config, --disable-c++11, libsdl1.2-dev libsdl-net1.2-dev liba52-dev lib...
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants