Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Move all custom engine options dialogs into the engine plugin #3348

Merged
merged 4 commits into from Sep 18, 2021

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Sep 5, 2021

This should slightly reduce the size of the detection plugin, and serves as a step towards fixing Trac #12345.

@ccawley2011 ccawley2011 force-pushed the engine-options-dynamic branch from f24de3a to c988bbb Sep 6, 2021
@bluegr
Copy link
Member

@bluegr bluegr commented Sep 11, 2021

Nice work!

The custom engine options are actually part of the detection though. At which part of the detection are these handled now?

@sev-
Copy link
Member

@sev- sev- commented Sep 18, 2021

Great, merging this.

@sev- sev- merged commit 2f99746 into scummvm:master Sep 18, 2021
8 checks passed
@ccawley2011 ccawley2011 deleted the engine-options-dynamic branch Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants