Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GRIM] Fix subtitle alignment for OpenGL with shaders #3354

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

@somaen
Copy link
Member

@somaen somaen commented Sep 7, 2021

This is a quick attempt at trying to fix the broken positioning of text in Grim when using the OpenGL shader renderer.

@eriktorbjorn noted that this may stem from the OpenGL (with shaders)-renderer lacking a proper implementation of getScreenBoundingBox, so I went ahead and adapted one.

This was done by comparing the getScreenBoundingBox implementations for EFMI/Grim in the OpenGL-renderer, and noticing that those were only different in how they got at their data, as there was already an implementation for EFMI in the shader-renderer, I copy pasted that code, and adapted the differences I found when comparing the OpenGL-implementation, which seems to improve things.

sev- and others added 2 commits Aug 28, 2021
Just copy-pasted the contents of the Escape from Monkey Island
code below, and made adjustments based on the diff between
the two functions as they are in the regular OpenGL renderer.
@sev-
Copy link
Member

@sev- sev- commented Sep 7, 2021

It is not just quick, but also fairly dirty :D You did not rebase your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants