Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: FREDDI - Hide knocker when door is opening, fixes bug #4776 #3364

Merged
merged 2 commits into from Sep 13, 2021

Conversation

@BenCastricum
Copy link
Contributor

@BenCastricum BenCastricum commented Sep 13, 2021

Tested with :

HE 71
"d4cccb5af88f3e77f370896e9ba8c5f9" win-en
"c0039ad982999c92d0de81910d640fa0" win-nl

HE 73
"64a22be96d679018696e5c8d3ca8b71d" win-jp
"cf8ef3a1fb483c5c4b1c584d1167b2c4" win-de
"5ebb57234b2fe5c5dff641e00184ad81" win-fr
"507bb360688dc4180fdf0d7597352a69" win-se

"746e88c172a5b7a1ae89ac0ee3ee681a" win-ru (HE 90)  No fix needed
"e63a0b9249b5ca4cc4d3ac34305ae360" win-nb (HE 99)  No fix needed
"3ae7f002d9256b8bdf76aaf8a3a069f8" wii-en (HE 100) No fix needed

HE90 and up do not use putState to hide the knocker, some other technique must be
used to hide it. Maybe the door is drawn on top of it.
@bluegr
Copy link
Member

@bluegr bluegr commented Sep 13, 2021

Quite a targeted workaround. Thanks for the development and testing! Merging

@bluegr bluegr merged commit f68e0c6 into scummvm:master Sep 13, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants