Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARK: Adding mechanism to correct subtitles #3394

Closed

Conversation

@Thunderforge
Copy link
Contributor

@Thunderforge Thunderforge commented Sep 30, 2021

Fixes #12967

If there are any additional subtitles that don't match the spoken dialogue, we can correct them too.

Corrected subtitle

_character = stream->readSint32LE();
}

Common::String Speech::correctSubtitle(Common::String phrase) {
Copy link
Contributor

@mgerhardy mgerhardy Sep 30, 2021

maybe do

_phrase = stream->readString();
correctSubtitle(_phrase);

then you don't have to copy the strings.

@aquadran aquadran closed this Oct 1, 2021
@Thunderforge Thunderforge deleted the 12967/correcting_subtitles branch Oct 1, 2021
@Thunderforge
Copy link
Contributor Author

@Thunderforge Thunderforge commented Oct 1, 2021

Thanks @bluegr for finding a better solution than mine!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants