Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STARK: Fix bad subtitle for Cortez in theater #3398

Merged
merged 1 commit into from Oct 1, 2021

Conversation

@antoniou79
Copy link
Contributor

@antoniou79 antoniou79 commented Oct 1, 2021

Fix for bug https://bugs.scummvm.org/ticket/12967

@bluegr
Copy link
Member

@bluegr bluegr commented Oct 1, 2021

I'm confused. Isn't that a similar fix with the one done in #3394?

@antoniou79
Copy link
Contributor Author

@antoniou79 antoniou79 commented Oct 1, 2021

I'm confused. Isn't that a similar fix with the one done in #3394?

Sorry, I did not notice there was an existing PR.

Just to defend my approach.

It addresses and fixes the same issue but I wanted to make the check for the change as specific as possible, so I filter by game language, character who speaks the line, and then the index (int), subType (int) and finally specific resource name ("Cortez_Laying low #1"), in order to avoid checking every loaded string against the faulty one.

@aquadran
Copy link
Member

@aquadran aquadran commented Oct 1, 2021

I agree with @antoniou79, this has better checks. this one should be merged

@aquadran aquadran merged commit 74a15b8 into scummvm:master Oct 1, 2021
8 checks passed
@Thunderforge
Copy link
Contributor

@Thunderforge Thunderforge commented Oct 1, 2021

I agree, this is a better fix than the one I was doing. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants