Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVTOOLS: simplify macbinary packing a bit #3401

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@einstein95
Copy link
Contributor

@einstein95 einstein95 commented Oct 3, 2021

No description provided.

@bluegr
Copy link
Member

@bluegr bluegr commented Oct 12, 2021

So, you're essentially changing xB63s4 to x64p4. But why have you removed the length?

@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented Oct 13, 2021

So, you're essentially changing xB63s4 to x64p4. But why have you removed the length?

As per the original MacBinary specifications, this field is a Pascal string

For more information on Pascal strings, https://docs.python.org/3/library/struct.html#format-characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants