Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KYRA: HOF: Fix hebrew multiword object action strings #3403

Merged
merged 1 commit into from Oct 4, 2021

Conversation

@BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Oct 4, 2021

Following #3277

This PR fixes the action string for multi-worded object in Hebrew fan translation of Kyrandia 2
as well as reversing the order of the sentence.

The game resource have objects names along with the indefinte article,
then, on command string, the engine removes the article and uppercase the first letter, e.g.
an empty flask -> Empty flask taken.

This logic caused object with multiple words to skip the first word in hebrew.

The reversing of the sentences is to avoid having to consider the object gender,
so the sentence become dependent on the player and not the object
(you (plural, indefinite) have dropped [object].) instead of ([object] placed (gender needs to match).)

Thanks

@athrxx
Copy link
Member

@athrxx athrxx commented Oct 4, 2021

Thanks!

@athrxx athrxx merged commit 77a7890 into scummvm:master Oct 4, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants