Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: GRIM: Support playing with mouse #3406

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@orgads
Copy link
Contributor

@orgads orgads commented Oct 5, 2021

Originally done by Tobias Pfaff tpfaff@berkley.edu and verticalduck vertigo80@gmx.net.

I kept it up-to-date, and cleaned up. Tested on Windows only.

@orgads
Copy link
Contributor Author

@orgads orgads commented Oct 5, 2021

The hotspots generator scripts/data can be moved elsewhere (scummvm-tools? Somewhere else?)

I'm unsure about all the Android icons and if/why they're needed.

It would probably be better to add an option for enabling/disabling mouse interaction.

@orgads
Copy link
Contributor Author

@orgads orgads commented Oct 5, 2021

I tried reaching out for Tobias asking for details about these changes 5 months ago, but he never replied.

@aquadran
Copy link
Member

@aquadran aquadran commented Oct 5, 2021

That patches were never merged because it was hack. Things are not changed on this matter now.
This is not ready for open PR. Are you going to work on this?

@orgads orgads changed the title GRIM: Support playing with mouse RFC: GRIM: Support playing with mouse Oct 5, 2021
@orgads
Copy link
Contributor Author

@orgads orgads commented Oct 5, 2021

Was it ever proposed? I can't find any PR here or on https://github.com/residualvm/residualvm.

I'd like to improve it. Do you have specific comments?

@aquadran
Copy link
Member

@aquadran aquadran commented Oct 5, 2021

It was never propose on PR. But we saw that patches in past. I general things needs fit into engine smoothly and not hack way. You need to review code and see what things do and how they works. Blinding accepting code without work on it is not an option. There must be someone who are willing to work on it and fix it/ improve things. From what I remember this functionally was not completed or fully worked.

@orgads orgads force-pushed the grim-mouse-squashed branch 5 times, most recently from 6a426fc to 5b21dac Oct 5, 2021
@BLooperZ
Copy link
Contributor

@BLooperZ BLooperZ commented Oct 5, 2021

Thanks @orgads

From what I remember this functionally was not completed or fully worked.

@aquadran It actually works quite well from my experience (I have played with @orgads's updated and cleaned up branch just before the merge of ResidualVM)

I also think the generator should be moved to devtools.
(Does it includes the build process of mouse.lab?)

probably should also add fallback to old behavior (= no mouse support) when mouse.lab is not available.

@orgads
Copy link
Contributor Author

@orgads orgads commented Oct 5, 2021

@BLooperZ mouse.lab is embedded in scummvm executable.

@aquadran I cleaned up a lot of debugging/hacks/datafiles, and reverted Android changes completely. The patch is much smaller now.

I consider the patch ready for initial review.

engines/grim/actor.cpp Outdated Show resolved Hide resolved
engines/grim/lua_v1_graphics.cpp Outdated Show resolved Hide resolved
engines/grim/sector.cpp Outdated Show resolved Hide resolved
@orgads orgads force-pushed the grim-mouse-squashed branch from 5b21dac to 2c7e11a Oct 6, 2021
engines/grim/actor.cpp Outdated Show resolved Hide resolved
engines/grim/actor.cpp Outdated Show resolved Hide resolved
engines/grim/cursor.cpp Outdated Show resolved Hide resolved
engines/grim/cursor.cpp Outdated Show resolved Hide resolved
engines/grim/emi/lua_v2_actor.cpp Outdated Show resolved Hide resolved
engines/grim/gfx_base.h Outdated Show resolved Hide resolved
engines/grim/gfx_opengl.cpp Outdated Show resolved Hide resolved
engines/grim/gfx_opengl.cpp Outdated Show resolved Hide resolved
engines/grim/gfx_opengl.cpp Outdated Show resolved Hide resolved
@orgads orgads force-pushed the grim-mouse-squashed branch 3 times, most recently from 2922f97 to aa67170 Oct 9, 2021
Originally done by Tobias Pfaff <tpfaff@berkley.edu> and
verticalduck <vertigo80@gmx.net>.
@orgads orgads force-pushed the grim-mouse-squashed branch from aa67170 to c791d8f Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants