Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Handle 0 byte Fmap in Cast::loadFontMapV4 #3408

Merged
merged 1 commit into from Oct 21, 2021

Conversation

@einstein95
Copy link
Contributor

@einstein95 einstein95 commented Oct 9, 2021

Stephen Jay Gould demo has a 0 byte Fmap which makes ScummVM crash. This is basically a copy/paste from Cast::loadFont.

Demo link

@rvanlaar
Copy link
Contributor

@rvanlaar rvanlaar commented Oct 10, 2021

This change results in a couple of broken games.
The main error seems to be: scummvm: common/stream.cpp:266: virtual bool Common::SeekableSubReadStream::seek(int64, int): Assertion _pos <= _end' failed.`

Have a look at: https://john.scummvm.org/#/changes/24365

@sev-
Copy link
Member

@sev- sev- commented Oct 21, 2021

Thank you, merging.

@sev- sev- merged commit b7ac932 into scummvm:master Oct 21, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants