TWINE: collection of fixes from master #3411
This was due to the engine both exiting immediately from the game loop and pushing a QUIT_EVENT (through the call to quitGame()). This meant that that QUIT_EVENT was processed only after the game had already returned to the launcher, causing the launcher to close. This fixes bug #12904
We now use a U32String for the savegame descriptions, but the code was calling c_str() directly on it, and the uint32 pointer was casted to a char pointer along the way. This resulted in only the first character of the description being displayed on little endian systems (and probably none on big endian systems since the first byte would be 0 for ASCII characters). This fixes bug #12869
This caused the description to be missing in the Grid View of the ScummVM saveload dialog for example.
This script patch caused the bug it claimed to fix. It appears that during SCI32 development in 2017, a bug sent the horse at Banbury Cross on an incorrect path behind the fountain instead of in front of it. This would have looked glitchy since the horse has a higher priority than the fountain. But this was misdiagnosed as a priority bug, even though the original doesn't have any problems, and the script was patched to set the horse to a lower priority. The real ScummVM bug was fixed some time later, and ever since the horse has taken the correct path and looked glitchy due to the patch setting the wrong priority.
The positions of the previous and next button had been mixed up. The previous button is left of the next button, not the other way around. This meant you could only be awarded points when pressing the previous button, and since you would then step away from the page that awards point that did not work. Since the buttons worked in other respects, the id for the previous and next pages must also have been similarly mixed up. This too should be fixed now.
The Agent 3 information and profile research points were awarded when pressing the "next" button, so they were never awarded. Award them when hitting a hotspot instead.
A few people have not noticed that the GOG version includes a CD image and some files need to be taken from there. This should help those people. The same problem will happen for anyone who has an old install of the game and forgets that it uses some files from the CD.
Because the games have different global sizes, the logic for when to print a pop-to-global warning was wrong. It should warn for size > 2 in Crusader (where the globals are *bytes*), or if the size popped doesn't fit in the number of *bits* for U8.
As reported in #12913, the current process loop detection can incorrectly fire on certain U8 map transitions. Bump the threshold way up to avoid problems. This will result in a nasty pause in Crusader: No Remorse Map 3, but it's better than breaking U8.
…887) The comment says it will clear the live text window, but instead disabled the navigation arrows (I think), which it then does again right aftewards. A cut and paste error, perhaps?
This fixes a crash on startup on RISC OS.
This commit adds separate detection entries for the Windows and Linux versions of Inherit The Earth. There was a combined DOS/Windows/Linux entry with DOS as the platform. It is not clear to me if this is a combined release or a single entry for three separate releases, but the Windows and Linux release do exist as separate releases. These would be detected with DOS as the platform, which would cause the music not to work, because the DOS, Windows and Linux versions use different music formats.
The engine expected all files listed in the detection entries to be resource files. This commit adds the option to use a non-resource file for detection. This is needed to use a MID file to detect one of the Windows versions of Inherit the Earth.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.