Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL: Fix exception on macOS 10.4/10.5 #3416

Merged
merged 1 commit into from Oct 14, 2021
Merged

SDL: Fix exception on macOS 10.4/10.5 #3416

merged 1 commit into from Oct 14, 2021

Conversation

@evanmiller
Copy link
Contributor

@evanmiller evanmiller commented Oct 11, 2021

The getBytes:...:remainingRange: API was introduced in macOS 10.6.

The getBytes:...:remainingRange: API was introduced in 10.6.
@criezy
Copy link
Member

@criezy criezy commented Oct 14, 2021

Thank you.

The Apple documentation indicates the function was introduced in 10.5 and not 10.6. But the change should indeed fix an issue on 10.4. I don't think it would be very complicated to make the code work on 10.4 as well (as opposed to doing nothing) but I am not sure it is worth the effort.

So I will merge this as is.

@criezy criezy merged commit a9a59ba into scummvm:master Oct 14, 2021
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants