Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENGL: Implement scaler support #3441

Merged
merged 6 commits into from Nov 20, 2021
Merged

OPENGL: Implement scaler support #3441

merged 6 commits into from Nov 20, 2021

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Oct 21, 2021

TODO:

  • Dirty rects don't always redraw correctly
  • Cursors aren't yet scaled
  • Needs testing on big endian with GLESv2

Fixes Trac #12848.

@ccawley2011 ccawley2011 marked this pull request as ready for review Oct 22, 2021
@sev-
Copy link
Member

@sev- sev- commented Nov 1, 2021

In fact, I consider this as a dead end. In my opinion, the proper way would be to add Shader-based scalers to the OpenGL.

Perhaps you would be curious and help @lotharsm finish this work which was started by LordHoto? https://github.com/lotharsm/scummvm/tree/shaderscaler

Loading

@aquadran
Copy link
Member

@aquadran aquadran commented Nov 1, 2021

I second on that, use shaders approach

Loading

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Nov 1, 2021

In fact, I consider this as a dead end. In my opinion, the proper way would be to add Shader-based scalers to the OpenGL.

Perhaps you would be curious and help @lotharsm finish this work which was started by LordHoto? https://github.com/lotharsm/scummvm/tree/shaderscaler

I'd definitely be interested in looking into shader support at some point. However, I feel it's still worthwhile having CPU scalers for a few reasons:

  • Since not all scalers are guaranteed to have shader counterparts, it ensures that the old scalers are always available, even on Android where only the OpenGL graphics manager is supported.
  • There has been some discussion in the past suggesting that it would be beneficial to have both scalers and shaders active at the same time in some cases: https://forums.scummvm.org/viewtopic.php?p=88798#p88798
  • It can potentially be backported to the 2.5 branch, resolving the confusion caused by the changed defaults on Windows and Mac OS X in the last release.

Loading

@aquadran
Copy link
Member

@aquadran aquadran commented Nov 1, 2021

having both scalers and shaders at same time make no sense for me. shaders can do scale at same time or rendered to proper frame buffer size.

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 1, 2021

Okay, sounds good. In this case, could you please implement the cursor scaling before we merge? Also, please add a note to the NEWS.md as part of this PR right away.

Loading

@ccawley2011
Copy link
Member Author

@ccawley2011 ccawley2011 commented Nov 16, 2021

Okay, sounds good. In this case, could you please implement the cursor scaling before we merge? Also, please add a note to the NEWS.md as part of this PR right away.

OK, done.

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 20, 2021

Thank you!

Loading

@sev- sev- merged commit ba564bc into scummvm:master Nov 20, 2021
8 checks passed
Loading
@ccawley2011 ccawley2011 deleted the opengl-scalers branch Nov 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants