Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Add detection for a few german games #3467

Merged
merged 1 commit into from Nov 3, 2021
Merged

Conversation

@besentv
Copy link
Contributor

@besentv besentv commented Oct 25, 2021

Some childhood games I still had laying around here.

@besentv
Copy link
Contributor Author

@besentv besentv commented Oct 25, 2021

This time using the WINGAME1t_l macro.

Loading

Copy link
Contributor

@trembyle trembyle left a comment

Thanks. This looks good with only some small adjustments needed.

Loading

engines/director/detection_tables.h Outdated Show resolved Hide resolved
Loading
engines/director/detection_tables.h Show resolved Hide resolved
Loading
engines/director/detection_tables.h Outdated Show resolved Hide resolved
Loading
@@ -658,6 +666,7 @@ static const PlainGameDescriptor directorGames[] = {
{ "ravensburger", "Ravensburger Interactive Demo-Sampler" },
{ "raveshuttle", "Rave Shuttle: The Cosmic Challenge" },
{ "tkkgkit", "TKKG: Identikit" },
{ "verkehr", "JANOSCH: Tiger und Bär im Straßenverkehr" },
Copy link
Contributor

@trembyle trembyle Oct 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have janosch in the game ID so that it appears next to the other game.

Loading

@besentv
Copy link
Contributor Author

@besentv besentv commented Oct 27, 2021

Sure, I will change these.

Loading

@besentv
Copy link
Contributor Author

@besentv besentv commented Oct 28, 2021

Not sure why the punycode detection doesn't work in the new commit.

Loading

Some childhood games I still had laying around here.
@besentv
Copy link
Contributor Author

@besentv besentv commented Oct 28, 2021

Got the punycode working!
What doesn't work is the detection from the root DVD folder. Probably because the games' executables are in a specific subfolder each, which are not in the detection paths file. Not really sure, if it's a great idea to put them there, though.

Loading

@trembyle
Copy link
Contributor

@trembyle trembyle commented Oct 29, 2021

the games' executables are in a specific subfolder each, which are not in the detection paths file. Not really sure, if it's a great idea to put them there, though.

Sure, try putting them in detection_paths.h and see if they're recognized.

Loading

@trembyle trembyle merged commit c80720d into scummvm:master Nov 3, 2021
8 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants