Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: Add more games, fix some entries #3470

Merged
merged 4 commits into from Nov 10, 2021

Conversation

@einstein95
Copy link
Contributor

@einstein95 einstein95 commented Oct 28, 2021

Additionally correct a few whitespace issues (tabs following spaces) and at least one spelling mistake

@einstein95 einstein95 force-pushed the director_detection branch 2 times, most recently from 8833b6e to 2c3555e Oct 29, 2021
@sev- sev- requested a review from trembyle Nov 1, 2021
Copy link
Contributor

@trembyle trembyle left a comment

@einstein95 let me know if and when this is ready to be reviewed.

If you'd like to keep it open until then, please move it into Draft state. If you think that you're going to just resubmit it, then we should close it.

Loading

@einstein95 einstein95 force-pushed the director_detection branch 2 times, most recently from aae86ca to 94c16c4 Nov 4, 2021
@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented Nov 4, 2021

@trembyle Ready to be reviewed now, I'll add a 2nd file for milo and milomagical now

Loading

@einstein95 einstein95 force-pushed the director_detection branch 4 times, most recently from f5bd326 to 5a39ff0 Nov 4, 2021
engines/director/detection_tables.h Outdated Show resolved Hide resolved
Loading
@@ -1901,7 +1985,8 @@ static const DirectorGameDescription gameDescriptions[] = {

MACDEMO1("pixar", "1993 Demo", "Pixar Projector", "1ae45c23586b41997ba52e2e7c771c4c", 2324198, 310),

MACDEMO1("playroom", "Color Demo", "Color Playroom Demo", "b29b31f423a332e7f9e059187e62e1be", 1000734, 300),
MACDEMO1("playroom", "Color Demo", "Color Playroom Demo", "b29b31f423a332e7f9e059187e62e1be", 1000478, 300),
// MACDEMO1("playroom", "Demo", "Demo", "b29b31f423a332e7f9e059187e62e1be", 1000478, 300),
Copy link
Contributor

@trembyle trembyle Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be commented? If not, can you add a second file?

Loading

Copy link
Contributor Author

@einstein95 einstein95 Nov 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That file is the only one in the folder and is identical to the existing demo

Loading

@@ -1930,7 +2017,8 @@ static const DirectorGameDescription gameDescriptions[] = {
MACGAME1_l("refixion3", "", "The Reindeer Story", "f5277c53bacd27936158dd3867e587e2", 392473, Common::JA_JPN, 300),

// Original Mac version is Director. Later DOS port uses MADE engine (also in ScummVM).
MACDEMO1("rodneyfs", "Demo", "Rodney's Funscreen demo", "9f0bb7ec7720e4f680ee3aa3d22c1c9d", 356866, 300),
MACDEMO1("rodneyfs", "Demo", "Rodney's Funscreen demo", "9f0bb7ec7720e4f680ee3aa3d22c1c9d", 356610, 300),
// MACDEMO1("rodneyfs", "Demo", "Sample Application", "9f0bb7ec7720e4f680ee3aa3d22c1c9d", 356610, 300),
Copy link
Contributor

@trembyle trembyle Nov 5, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this one commented?

Loading

Copy link
Contributor Author

@einstein95 einstein95 Nov 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similarly to the playroom demo above, the genericness of the filename and it being identical to the existing demo is why I commented it

Loading

@einstein95 einstein95 force-pushed the director_detection branch 5 times, most recently from 45d5e7e to 91dc88e Nov 6, 2021
@einstein95 einstein95 force-pushed the director_detection branch from 91dc88e to 901decb Nov 10, 2021
@trembyle trembyle merged commit ba4fbd2 into scummvm:master Nov 10, 2021
5 of 8 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants