Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: add new variants of existing games #3471

Merged
merged 2 commits into from Nov 3, 2021

Conversation

@mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Oct 30, 2021

This adds several new variants of games that are already in ScummVM; some are full versions of demos, others are language variants. Some notes:

Jungle Park:

  • ScummVM immediately closes with an error in the console: Cast::loadConfig(): Wrong format. VWCF resource missing!

Peace Land:

  • ScummVM closes immediately after loading. The console complains about not being able to locate a score with a specific name, several unimplemented xlibs, an unhandled movie resource, and an unhandled PICT resource.

Pickle's Book:

  • The Windows and Mac versions seem to have been compiled with different Director versions.
  • Gets to the title screen correctly, then hangs with glitchy audio.

Pyramid Interactive:

  • Immediately throws an in-ScummVM error from inside Cast::loadCastDataVWCR()

World Engine Fantazation:

  • The Windows version boots up to an error about not being able to load textures.
  • The Mac version has a Lingo syntax error.
@mistydemeo mistydemeo force-pushed the add_new_game_versions branch 2 times, most recently from 1515a9f to d826346 Oct 30, 2021
@mistydemeo
Copy link
Contributor Author

@mistydemeo mistydemeo commented Oct 30, 2021

Added the original 1991 version of Alice, and added a comment to the D2 version the tables already had to note that it's a rerelease. I believe that's the 1992 digipak release.

The Mac versions of Alice were victims to the size misdetection bug, so I've updated the table with the correct filesizes.

Loading

@mistydemeo mistydemeo force-pushed the add_new_game_versions branch from d826346 to 923a568 Oct 31, 2021
@sev- sev- requested a review from trembyle Nov 1, 2021
Copy link
Contributor

@trembyle trembyle left a comment

Thanks, this looks great.

See my question under Alice. If the answer is no, then that's fine too.

Loading

engines/director/detection_tables.h Outdated Show resolved Hide resolved
Loading
Copy link
Contributor

@trembyle trembyle left a comment

Just another question on the Alice releases. Otherwise this all looks good to merge.

Loading

engines/director/detection_tables.h Show resolved Hide resolved
Loading
@mistydemeo mistydemeo force-pushed the add_new_game_versions branch from 923a568 to 9f08d6e Nov 3, 2021
@trembyle trembyle merged commit f00326f into scummvm:master Nov 3, 2021
8 checks passed
Loading
@mistydemeo mistydemeo deleted the add_new_game_versions branch Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants