Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVTOOLS: Add test for previous dumpercompanion workaround, other changes #3485

Merged
merged 1 commit into from Nov 3, 2021

Conversation

@einstein95
Copy link
Contributor

@einstein95 einstein95 commented Nov 3, 2021

Use "MacJapanese" instead of "Mac Japanese", remove commented code from previous PR. These were requested by @rvanlaar

@bluegr
Copy link
Member

@bluegr bluegr commented Nov 3, 2021

Thanks for the fixes! Merging

Loading

@bluegr bluegr merged commit ad61259 into scummvm:master Nov 3, 2021
8 checks passed
Loading
@gingerbeardman
Copy link

@gingerbeardman gingerbeardman commented Nov 3, 2021

I just came across some other characters that are not dealt with, and upon reading the MacJapanese spec it seems mapping of Shift+JIS ranges is missing from the Japanese logic.

see: "Unicode mapping issues and notes"
ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/APPLE/JAPANESE.TXT

  1. Mapping the user-defined range

    The table below covers only the standard Mac OS Japanese encoding.
    It does not include mappings for the Shift-JIS user-defined range;
    this is mapped onto Unicodes 0xE000-0xE98B as follows:
    0xF040-0xF07E -> 0xE000-0xE03E
    0xF080-0xF0FC -> 0xE03F-0xE0BB
    0xF140-0xF17E -> 0xE0BC-0xE0FA
    0xF180-0xF1FC -> 0xE0FB-0xE177
    ...
    0xFC40-0xFC7E -> 0xE8D0-0xE90E
    0xFC80-0xFCFC -> 0xE90F-0xE98B

Loading

@gingerbeardman
Copy link

@gingerbeardman gingerbeardman commented Nov 3, 2021

Sadly I don't know Python well enough to code a map like that efficiently.

Loading

@gingerbeardman
Copy link

@gingerbeardman gingerbeardman commented Nov 4, 2021

My WIP is at gingerbeardman@39f4133

Loading

@rvanlaar
Copy link
Contributor

@rvanlaar rvanlaar commented Nov 15, 2021

@gingerbeardman Thank you for bringing this to our attention. The mapping was automatically generated. We're looking into regenerating it with the included Shift-JIS ranges

Loading

@gingerbeardman
Copy link

@gingerbeardman gingerbeardman commented Nov 15, 2021

My final solution to my task of generating directory listings of these old discs uses hfsutils (for raw directory listings) plus a small Tcl script (to do the re-encoding).

So, all this to say I probably won't find time to clean up my PR. Feel free to use any part of it or abandon it altogether and close it.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants