Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVTOOLS: MacJapanese mapping of SHIFT-JIS range, log levels, typo fixes #3495

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

@gingerbeardman
Copy link

@gingerbeardman gingerbeardman commented Nov 7, 2021

My use case for this tool is to generate directory listings of Japanese Macintosh CD-ROMs for search, archiving and preservation purposes.

So, my modifications are regarding:

  • getting valid display of the raw MacJapanese filenames (including MacRoman, SHIFT-JIS range and other craziness)
  • being able to run the tool without writing anything to disk
  • keeping logging separate from the regular output.

Changelog

  • Added MacJapanese mapping of SHIFT-JIS range (please test/verify)
    (see: Unicode mapping issues and notes in APPLE/JAPANESE.TXT)

  • Added --dryrun, do not write any files to disk

  • Added --nopunycode, never encode pathnames into punycode
    (as even without --punycode there is still some punycode generated in extract_volume)

  • Added --log, log levels and changed info/warning print statements to logging

Testing

@sev-
Copy link
Member

@sev- sev- commented Nov 7, 2021

Your commit log messages do not conform to our commit guidelines. Please fix

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 7, 2021

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 23, 2021

Thank you, great idea with dryrun.

Could you, please, however:

  1. Rebase this, so it will merge cleanly
  2. Reword the commit log messages according to our Commit Guidelines, particularly, so the all are more descriptive (maybe squash some of them) and have a prefix "DEVTOOLS: COMPANION: ....."

Loading

@gingerbeardman
Copy link
Author

@gingerbeardman gingerbeardman commented Nov 24, 2021

@sev- not sure if/when I will find the time

I am happy if somebody else wants to complete this.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants