Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: close file handles when no stream created #3496

Merged
merged 1 commit into from Nov 7, 2021

Conversation

@mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Nov 7, 2021

getAudioStream() was leaking file descriptors. The caller closes the file if a stream could be created, but in the case one isn't then the file will never be closed. In the worst case scenario, it could hit the descriptor table size and prevent any further file open calls from working.

cc @moralrecordings

@sev-
Copy link
Member

@sev- sev- commented Nov 7, 2021

Good catch. thank you!

Loading

@sev- sev- merged commit 6d32f57 into scummvm:master Nov 7, 2021
5 of 8 checks passed
Loading
@mistydemeo mistydemeo deleted the sound_close_streams branch Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants