Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: decode movie paths before loading #3507

Merged
merged 1 commit into from Nov 9, 2021

Conversation

@mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Nov 9, 2021

This fixes an issue where movies in probeMacBinary weren't being decoded before being loaded. In the case of Japanese games that used MacJapanese filenames, this could lead to errors loading them. Before the patch:

WARNING: Couldn't find score with name: WackyRaces: WackyRaces: Main:�Entrance!

After:

WARNING: Replaced score name with:  WackyRaces: Main:・Entrance (from WackyRaces: WackyRaces: Main:・Entrance)!

This fixes loading a scene in the Mac version of Wacky Races, though it still doesn't make it past the intro video.

@mistydemeo mistydemeo force-pushed the fix_resource_load_encoding branch from 95e06da to 7c6df35 Nov 9, 2021
@djsrv djsrv merged commit 1750ecf into scummvm:master Nov 9, 2021
5 of 8 checks passed
Loading
@djsrv
Copy link
Member

@djsrv djsrv commented Nov 9, 2021

Thanks!

Loading

@mistydemeo mistydemeo deleted the fix_resource_load_encoding branch Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants