Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENDINGUX: Various improvements to building process #3517

Merged
merged 4 commits into from Nov 12, 2021

Conversation

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Nov 11, 2021

This PR embeds the various platforms supported by OpenDingux beta directly in the configure script.
This will allow the buildbot to include builds for these platforms as it can't use the release build script.

In addition some autodetections are enabled back to allow make use of the features on GCW0 (Fluidsynth, Theora, SDL2) and OpenGL ES2 is enabled on GCW0 as the toolchain provides Mesa.

Some small fixes are provided to the make-opk script and the build_odbeta is reworked to make use of configure changes and to make use of arguments instead of environment variables to create the build.

@lephilousophe lephilousophe requested a review from citral23 Nov 11, 2021
Copy link
Contributor

@citral23 citral23 left a comment

Very well, it is indeed a good option to automate the builds more easily.

Loading

Copy link
Contributor

@citral23 citral23 left a comment

Hi, do you have a jz4770 device to test it yourself?

Because in my testing :

Fluidsynth doesn't work (unfortunately, it would be nice)
Theora is too slow (we have no HW accel at all, mpeg2 in game videos run at 3fps to give you an idea)
SDL2 brings no benefit, as it's much, much slower than SDL1 for software rendering and gles2/es2 crashes (haven't looked why yet)

Loading

configure Outdated Show resolved Hide resolved
Loading
@lephilousophe
Copy link
Member Author

@lephilousophe lephilousophe commented Nov 11, 2021

I don't have the hardware but, as libraries were present in the toolchain, I expected device was powerful enough for them.
I removed the commit which enabled all of this.

Loading

@citral23
Copy link
Contributor

@citral23 citral23 commented Nov 11, 2021

I don't have the hardware but, as libraries were present in the toolchain, I expected device was powerful enough for them. I removed the commit which enabled all of this.

Yeah, I hoped and tried too, but while fairly capable for what it is, it's still a single core 1GHz cpu

  • Not nearly enough for Fluidsynth, and Timidity doesn't work unfortunately (mixed them up in my previous comment). I think fluidsynth should be removed from the toolchain.
  • Theora works on mpv at around 240/272p but without HW accel it won't go above that.
  • GLES2 works with some other software, but crashes on scummvm. I will look into it later down the road, but for now it's better to disable it.

Loading

@lephilousophe
Copy link
Member Author

@lephilousophe lephilousophe commented Nov 11, 2021

OK, that's done.

Loading

@lephilousophe lephilousophe merged commit 724dcd3 into scummvm:master Nov 12, 2021
5 of 8 checks passed
Loading
@lephilousophe lephilousophe deleted the fix-od branch Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants