Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVTOOLS: add Mac fonts to gitignore #3520

Merged
merged 1 commit into from Nov 11, 2021

Conversation

@mistydemeo
Copy link
Contributor

@mistydemeo mistydemeo commented Nov 11, 2021

A few other devtools-generated data files that aren't tracked in git are in this .gitignore to prevent them showing up as untracked files to git. I think it makes sense to add these two files as well. They're generated by two scripts in devtools.

@aquadran aquadran merged commit de323d6 into scummvm:master Nov 11, 2021
8 checks passed
Loading
@mistydemeo mistydemeo deleted the gitignore_japanese_fonts branch Nov 11, 2021
@sev-
Copy link
Member

@sev- sev- commented Nov 13, 2021

I wonder, why. Those files should not be in that directory unless you set it as your 'extra' directory.

Loading

@mistydemeo
Copy link
Contributor Author

@mistydemeo mistydemeo commented Nov 13, 2021

This is the default extras directory when building from source.

Loading

@sev-
Copy link
Member

@sev- sev- commented Nov 14, 2021

Interesting, could you point to the code where this default is set?

Loading

@mistydemeo
Copy link
Contributor Author

@mistydemeo mistydemeo commented Nov 14, 2021

Maybe I'm wrong! I never customized that path AFAICT and it's where it's loading them from though. It's also where I was recommended to put them in Discord.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants