Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XEEN: fix possible crash in exchange dialog #3536

Merged

Conversation

@benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Nov 14, 2021

Don't try to exchange a character with themself...

Steps to reproduce:

  • open the character panel
  • press 'e' to exchange
  • select the current character

→ trigger the assert in https://github.com/scummvm/scummvm/blob/master/engines/xeen/item.cpp#L138 because the source and destination array are the same.

Don't try to exchange a character with themself...
@dreammaster dreammaster merged commit 77f935b into scummvm:master Nov 17, 2021
8 checks passed
Loading
@benoit-pierre benoit-pierre deleted the xeen_fix_possible_exchange_crash branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants