Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OPENGL: Implement cursor scaling" #3555

Merged
merged 1 commit into from Nov 21, 2021

Conversation

@ccawley2011
Copy link
Member

@ccawley2011 ccawley2011 commented Nov 20, 2021

In the long term, a better way to fix the issue is to split the ScalerPluginObject class into two parts, so that each texture can have a separate instance of the scaler's internal state. For now, though, reverting this commit fixes Trac #13086. The normal and advmame scaler were the only ones that supported cursor scaling to begin with, so this shouldn't be a major loss.

@aquadran aquadran merged commit 35adc96 into scummvm:master Nov 21, 2021
8 checks passed
Loading
@sev-
Copy link
Member

@sev- sev- commented Nov 21, 2021

This is not acceptable. Without the cursor scaling, we would not merge the original PR. Now we ended up with a half-baked feature that affects most of the desktop users (OpenGL is the default on all major platforms).

Loading

@ccawley2011 ccawley2011 deleted the revert-cursor-scaling branch Nov 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants