Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CGE/CGE2: Don't pass the engine object to EncryptedStream #3639

Merged
merged 2 commits into from Jan 3, 2022

Conversation

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Jan 3, 2022

It doesn't need it and when linked with detection and with UBSan enabled build fails because CGEEngine and CGE2Engine aren't linked in

It doesn't need it and when linked with detection and with UBSan enabled
build fails because CGEEngine isn't linked in
It doesn't need it and when linked with detection and with UBSan enabled
build fails because CGE2Engine isn't linked in
@lephilousophe lephilousophe requested a review from Strangerke Jan 3, 2022
@bluegr
Copy link
Member

@bluegr bluegr commented Jan 3, 2022

Nice work!
That's quite a straightforward and logical change, there's no real need for a review here, so I'm merging this

@bluegr bluegr merged commit 4113d2a into scummvm:master Jan 3, 2022
8 checks passed
@lephilousophe lephilousophe deleted the ubsan-cge branch Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants