Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: Fix various memory leaks related to grid widget #3642

Merged
merged 1 commit into from Jan 6, 2022

Conversation

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented Jan 3, 2022

These were found with ASan.
I am not sure why themepath and iconspath handling are different.

@lephilousophe lephilousophe requested a review from sev- Jan 3, 2022
@bluegr
Copy link
Member

@bluegr bluegr commented Jan 3, 2022

Looks good! Well done

bluegr
bluegr approved these changes Jan 3, 2022
gui/gui-manager.cpp Show resolved Hide resolved
@bluegr
Copy link
Member

@bluegr bluegr commented Jan 6, 2022

Thanks for your work. I've tried these changes locally, and everything works as expected. Merging

@bluegr bluegr merged commit 1b3ac06 into scummvm:master Jan 6, 2022
8 checks passed
@lephilousophe lephilousophe deleted the grid-memleaks branch Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants