Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENGINES: Fix autosave name check #3648

Merged
merged 5 commits into from Jan 13, 2022
Merged

Conversation

@Die4Ever
Copy link
Member

@Die4Ever Die4Ever commented Jan 6, 2022

Save names in Groovie are limited to 15 characters, and it's probably not the only engine with a similar limit, I wanted to see if there was any interest in a global fix that could help many engines.

The length of the German translation for Autosave is 23 characters. This meant you would get a warning on every autosave, even though you just told it to overwrite.

I currently have it set to a minimum of 14 characters for confidence that the name is a match and not a false positive, but this could definitely be reduced.

@Die4Ever Die4Ever changed the title Fix autosave german ENGINES: Fix autosave name check Jan 6, 2022
engines/savestate.cpp Outdated Show resolved Hide resolved
engines/savestate.cpp Outdated Show resolved Hide resolved
@orgads
Copy link
Contributor

@orgads orgads commented Jan 12, 2022

Is _("Autosave") more than 15 chars (bytes) because of unicode/punycode, translation or something else?

@Die4Ever
Copy link
Member Author

@Die4Ever Die4Ever commented Jan 12, 2022

Is _("Autosave") more than 15 chars (bytes) because of unicode/punycode, translation or something else?

The German translation was very long, which was how this issue was discovered by my German friend, the translation is Automatisches Speichern

orgads
orgads approved these changes Jan 13, 2022
@Die4Ever Die4Ever merged commit 0d36402 into scummvm:master Jan 13, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants