Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBasic OUYA support #372
Conversation
This comment has been minimized.
This comment has been minimized.
Does this have any impact on our stock Android port? If not, we could simply merge this or is there still something you want to have done before? Or is anyone familiar with our Android port seeing problems here? |
This comment has been minimized.
This comment has been minimized.
On 12 August 2013 09:56, Johannes Schickel notifications@github.com wrote:
From reading the patch, it's as the description says: it adds support for Looks safe to just merge to me. |
This comment has been minimized.
This comment has been minimized.
The joystick support might be a gain for other device users, even. I'm not convinced about the target name though indeed: maybe at least call it android-tegra3 or android-neon or something? |
This comment has been minimized.
This comment has been minimized.
@lordhoto The impact on stock Android would be that the 109K ouya_icon.png is completely useless on non-ouya systems. The new code is potentially useable on any android system, and the extra intent adds negible bloat. So the question is if those 109K warrant a separate APK, or whether there is more to be gained by keeping just one. As for merging, there is certainly more that could be done, but I'd prefer to do it post-merge to inspire others to do work and testing as well. @fuzzie Well, the idea was that it should be simple for someone wanting to build an ouya binary to select the correct target. But I don't have a strong opinion on this. Still, there's no reason why the configure script couldn't recognized both "ouya" and "android-tegra3" at the same time... |
This comment has been minimized.
This comment has been minimized.
They are using their 'OUYA SDK', thus recognising that as a target has certain advantages. What this code is missing is detecting version of that SDK, and we need to specify the compatibility clearly, so in case of future incompatible changes by OUYA we will not end up with non-building port. |
This comment has been minimized.
This comment has been minimized.
This pull request does not use anything from the "OUYA SDK". The OUYA SDK contains two things AFAIK:
We don't need any of this, so OUYA SDK is not needed. |
This comment has been minimized.
This comment has been minimized.
OK to merge from me. |
This comment has been minimized.
This comment has been minimized.
Since almost a month has gone by on this, and both @sev- and @lordhoto are happy from a common code perspective and @anguslees and @fuzzie are fine from the Android specific code side... and I am happy reading through the changes, I am going to merge this... I am also going to add a ouya build target to our buildbot to build this so we can see if this does build happily with the standard android toolchain! :) Merging... |
zeldin commentedAug 8, 2013