Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic OUYA support #372

Merged
merged 6 commits into from Oct 9, 2013

Conversation

@zeldin
Copy link
Member

zeldin commented Aug 8, 2013

  • ScummVM is now playable on OUYA with either controller or Bluetooth mouse (mouse or touchpad recommended; joystick control still requires some work)
  • ScummVM appears as a "GAME" in the OUYA launcher
  • "ouya" is recognized as a target by configure, enabling Tegra3 optimizations
@lordhoto

This comment has been minimized.

Copy link
Member

lordhoto commented Aug 11, 2013

Does this have any impact on our stock Android port? If not, we could simply merge this or is there still something you want to have done before? Or is anyone familiar with our Android port seeing problems here?

@anguslees

This comment has been minimized.

Copy link
Member

anguslees commented Aug 12, 2013

On 12 August 2013 09:56, Johannes Schickel notifications@github.com wrote:

Does this have any impact on our stock Android port? If not, we could
simply merge this or is there still something you want to have done before?
Or is anyone familiar with our Android port seeing problems here?

From reading the patch, it's as the description says: it adds support for
joystick, middle mouse button and extra launch intent/icons presumably used
by OUYA in some way (all safe on other Android devices). There's also a
new --host=ouya target that sets some slightly different compiler arch
optimisations (also safe, but this approach won't scale to every variation
of Android device out there).

Looks safe to just merge to me.

@fuzzie

This comment has been minimized.

Copy link
Member

fuzzie commented Aug 12, 2013

The joystick support might be a gain for other device users, even. I'm not convinced about the target name though indeed: maybe at least call it android-tegra3 or android-neon or something?

@zeldin

This comment has been minimized.

Copy link
Member Author

zeldin commented Aug 12, 2013

@lordhoto The impact on stock Android would be that the 109K ouya_icon.png is completely useless on non-ouya systems. The new code is potentially useable on any android system, and the extra intent adds negible bloat. So the question is if those 109K warrant a separate APK, or whether there is more to be gained by keeping just one.

As for merging, there is certainly more that could be done, but I'd prefer to do it post-merge to inspire others to do work and testing as well.

@fuzzie Well, the idea was that it should be simple for someone wanting to build an ouya binary to select the correct target. But I don't have a strong opinion on this. Still, there's no reason why the configure script couldn't recognized both "ouya" and "android-tegra3" at the same time...

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Aug 18, 2013

They are using their 'OUYA SDK', thus recognising that as a target has certain advantages.

What this code is missing is detecting version of that SDK, and we need to specify the compatibility clearly, so in case of future incompatible changes by OUYA we will not end up with non-building port.

@zeldin

This comment has been minimized.

Copy link
Member Author

zeldin commented Aug 18, 2013

This pull request does not use anything from the "OUYA SDK". The OUYA SDK contains two things AFAIK:

  • In-game purchasing
  • Convenience functions for management of multiple gamepads

We don't need any of this, so OUYA SDK is not needed.

@sev-

This comment has been minimized.

Copy link
Member

sev- commented Sep 12, 2013

OK to merge from me.

@digitall

This comment has been minimized.

Copy link
Member

digitall commented Oct 9, 2013

Since almost a month has gone by on this, and both @sev- and @lordhoto are happy from a common code perspective and @anguslees and @fuzzie are fine from the Android specific code side... and I am happy reading through the changes, I am going to merge this... I am also going to add a ouya build target to our buildbot to build this so we can see if this does build happily with the standard android toolchain! :)

Merging...

digitall pushed a commit that referenced this pull request Oct 9, 2013
@digitall digitall merged commit d4d90b3 into scummvm:master Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.