Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GUI: (SaveLoad) - remove unnecessary dialog #3844

Merged
merged 1 commit into from May 12, 2022
Merged

Conversation

athrxx
Copy link
Member

@athrxx athrxx commented Apr 29, 2022

This is about the removal of the dialog

"WARNING: Existing save has longer gameplay duration than the current state. Are you sure you want to overwrite it?"

I think it has more negative than positive impact on the user experience, so I'd remove it.

I recently asked in the discord dev channel about it, but there wasn't much response. @dreammaster, @sluicebox and myself really don't like that dialog, but it is unclear whether everyone else thinks it is a great idea to have it.

The dialog

"WARNING: Existing save has longer gameplay duration than the current state. Are you sure you want to overwrite it?"

is not really helpful and seems to have more negative than positive impact on the user experience, so I have removed it.
@bluegr
Copy link
Member

@bluegr bluegr commented Apr 29, 2022

I also agree that this dialog is unnecessary and annoying, and removing it is the best course of action

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented May 3, 2022

This comes from #3308

@athrxx
Copy link
Member Author

@athrxx athrxx commented May 3, 2022

This comes from #3308

I am not sure if that is supposed to be an argument in favor of that dialog.
If yes: okay, I see that @SEV said "Very good addition, thank you." and @blugr said "Very nice indeed! Thanks, +1 from me too" .

But at least @bluegr apparently has changed his mind about that dialog. He now calls it "unnecessary and annoying". ;-)
Which IMHO really is the proper description for it.

So, maybe sev has started to hate that dialog, too?

It is the whole point of this PR to evaluate whether we can remove that dialog or whether it is considered to be an improvement.

@bluegr
Copy link
Member

@bluegr bluegr commented May 3, 2022

Yeah, my initial thoughts were that this dialog would be a useful feature. It has proven to be quite annoying sometimes, without providing any real value.

Perhaps we could keep it for regular saves only (not auto saves)? Or to provide an option to turn it off?

@athrxx
Copy link
Member Author

@athrxx athrxx commented May 3, 2022

Let me assure you that is exactly as annoying for non-auto saves. I don't even use auto saving.

Whenever I save something in a SCUMM or SCI game in an existing slot it will randomly question my decision with that pointless dialog. The playing time in that save slot is completely irrelevant for me. I don't want to be asked that.

I have never seen that sort of behaviour in any professional product. But maybe that's just me? Does anyone think/know that this is the normal thing for a game to do?

@lephilousophe
Copy link
Member

@lephilousophe lephilousophe commented May 3, 2022

This comes from #3308

I am not sure if that is supposed to be an argument in favor of that dialog. If yes: okay, I see that @SEV said "Very good addition, thank you." and @blugr said "Very nice indeed! Thanks, +1 from me too" .

Sorry if it was not clear, it was only a reminder from where this dialog comes because I wondered too.
I don't have any opinion about this but IIRC it came because some times the autosave feature erased an existing save. It's kind of blurry in my mind.

@athrxx
Copy link
Member Author

@athrxx athrxx commented May 12, 2022

Okay, turns out nobody voted in favour of the dialog. Merging...

@athrxx athrxx merged commit ea39342 into scummvm:master May 12, 2022
8 checks passed
@athrxx athrxx deleted the gui-nag-message branch May 12, 2022
@bonki
Copy link
Member

@bonki bonki commented May 12, 2022

Sorry, I'm late to the game and I see this has been merged already, but can't we turn this into a setting? While I don't have a strong opinion either way I wouldn't be surprised if there were users out there who appreciate(d) this feature.

@athrxx
Copy link
Member Author

@athrxx athrxx commented May 12, 2022

I can only repeat myself: Have you ever seen that sort of behavior in any professional game product?

@bonki
Copy link
Member

@bonki bonki commented May 12, 2022

No, but I do happen to have overwritten the wrong savegames at some point which this could have prevented :) So, I don't see it as an utterly useless feature.
Personally, I haven't used it but that's only because I haven't done any work on the code base or played any games since this was introduced (which, to be fair, also means that I don't know how annoying it really is when used), but I don't see anything wrong with keeping it but have it default to disabled.
As I said, I don't have a very strong opinion and if I'm the only one who would keep it around as an option I'm fine with it being gone, I just think it might be useful as long as it's not permanently enforced or the default.

@athrxx
Copy link
Member Author

@athrxx athrxx commented May 12, 2022

introduced (which, to be fair, also means that I don't know how annoying it really is when used),

Well, let me just quote a team member on that topic whose description of the issue seems to be in perfect match with my own experience:
i fly into a fucking rage every time i'm hit with it, which is basically every time i overwrite a save, which is constantly

@bonki
Copy link
Member

@bonki bonki commented May 12, 2022

Haha, fair. Hence my proposal to keep it as non-default setting. You asked for team feedback and those are my two cents, that's all. But let's keep it buried since that seems to be the consensus.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants