Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCUMM: Add Hebrew font for zak and MM #3856

Merged
merged 3 commits into from May 7, 2022
Merged

Conversation

ShaharAriel
Copy link
Contributor

@ShaharAriel ShaharAriel commented May 3, 2022

The replacement character tables override English letter A-Z (+1).
The replacement character tables have been created using the make-charset-fontdata tool.

The replacement character tables have been created using the make-charset-fontdata tool.
engines/scumm/charset-fontdata.cpp Outdated Show resolved Hide resolved
engines/scumm/charset-fontdata.cpp Outdated Show resolved Hide resolved
ShaharAriel and others added 2 commits May 3, 2022
Fix some indentation and remove unnecessary parentheses

Co-authored-by: Filippos Karapetis <bluegr@gmail.com>
Remove the game.id check conditions.
@ShaharAriel
Copy link
Contributor Author

@ShaharAriel ShaharAriel commented May 5, 2022

Why this 257ef41 commit failed, the error is:

 Error: Failed to download from mirror set:
 https://github.com/fribidi/fribidi/archive/v1.0.11.tar.gz: failed: status code 502

Is the error related to a commit message format (created automatically from github) that is not as guides? However, the cause of the error does not appear to be so.

@bluegr
Copy link
Member

@bluegr bluegr commented May 7, 2022

Thanks for your work on this! Merging

@bluegr bluegr merged commit cff061d into scummvm:master May 7, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants