Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DIRECTOR: LINGO: Implement MENUREF Datum type and STUB for Menu, Menus, MenuItem and MenuItems [WIP] #3859

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

r41k0u
Copy link
Contributor

@r41k0u r41k0u commented May 4, 2022

This change:

  • Implements the MENUREF Datum type to refere to menus and menuItems
  • Implements the missing getter and setter functions for the STUB.
  • Cleans up the old way of findMenuItem() (It would have required 4 overloads)
    With these changes, all the workshop movies concerning the menus and menuItems are working, except for the name of menu workshop movie.
    This is still WIP to figure out the problem with name of menu, fix it and then it would be a PR which could be merged

@rvanlaar
Copy link
Contributor

@rvanlaar rvanlaar commented May 8, 2022

Good work. I'ld like to see two changes for me to merge the PR.
Please clean up the commits:

  • remove the first commit: it has changes that are made irrelevant by the second commit
  • explain the why and how on the second commit

@r41k0u r41k0u changed the title DIRECTOR: Fix c_themenuitementityassign assigning the menuItems DIRECTOR: remove c_themenuitementityassign and move to c_theentityassign May 10, 2022
@r41k0u
Copy link
Contributor Author

@r41k0u r41k0u commented May 10, 2022

Done

@rvanlaar
Copy link
Contributor

@rvanlaar rvanlaar commented May 10, 2022

Hi @r41k0u
Yes, I see the first part, thank you. But you seem to have missed the second part.

@r41k0u r41k0u changed the title DIRECTOR: remove c_themenuitementityassign and move to c_theentityassign DIRECTOR: remove c_themenuitementityassign and move to c_theentityassign to implement kTheMenuItem STUB and remove duplicacy of code May 12, 2022
@r41k0u r41k0u changed the title DIRECTOR: remove c_themenuitementityassign and move to c_theentityassign to implement kTheMenuItem STUB and remove duplicacy of code DIRECTOR: remove kTheMenuItem STUB in setTheEntity() and get rid of c_themenuitementityassign to remove duplicacy May 12, 2022
@bluegr
Copy link
Member

@bluegr bluegr commented May 12, 2022

@r41k0u Please change your commit message according to our guidelines (you removed the DIRECTOR: part)

…_themenuitementityassign to remove duplicacy
@r41k0u r41k0u changed the title DIRECTOR: remove kTheMenuItem STUB in setTheEntity() and get rid of c_themenuitementityassign to remove duplicacy DIRECTOR: LINGO: Implement MENUREF Datum type and STUB for Menu, Menus, MenuItem and MenuItems [WIP] May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants