TINSEL: Implement a solution for INV_OBJECT being different in Noir, and add basic support for menus. #3866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
somaen
changed the title
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
bluegr
reviewed
May 8, 2022
|
Great and clean approach! |
This way we encapsulate the iteration, thus making sure that the appropriate stride is used (Noir has more fields).
|
Excellent work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This adds a (slightly over-engineered) way to resolve the size difference between INV_OBJECT in Noir and before, and relies on inheritance to provide the new fields.
Also this adds very basic menu support (save/load menus work, the options menu itself works, but the actual sub menus are not fully implemented yet).
To provide the mapping, the way the versioning is handled for the menu tables has been modified slightly, to avoid nesting ternaries.
Hence I think it's worthwhile to get this reviewed before pushing it, in case I've misunderstood something about the engine.