Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE_PROJECT: Add /Zc:__cplusplus so __cplusplus macro matches C++ feature level #3868

Merged
merged 1 commit into from May 13, 2022

Conversation

elasota
Copy link
Contributor

@elasota elasota commented May 9, 2022

Fixes https://bugs.scummvm.org/ticket/13471

By default, VS sets the __cplusplus macro to the C++98 value regardless of what feature level the compiler is configured to allow, so some code checking the value of the macro for C++11 feature support is not compiling. This enables the compliant behavior.

@bluegr
Copy link
Member

@bluegr bluegr commented May 13, 2022

Nice catch! This will help us enable the C++ 11 code paths in the code. For reference:

https://docs.microsoft.com/en-us/cpp/build/reference/zc-cplusplus?view=msvc-170

Merging

@bluegr bluegr merged commit 5f0c6fa into scummvm:master May 13, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants