Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PRINCE: Fix reading translation texts on big-endian systems #3870

Merged

Conversation

dwatteau
Copy link
Contributor

@dwatteau dwatteau commented May 10, 2022

The following diff prevents a crash on big-endian PowerPC when any subtitle is about to be printed in Galador.

It looks like PrinceEngine::setMobTranslationTexts() is the only place where the READ_() macro missed its endianness value, so it would just read in native endianness (and thus fail on big-endian systems, since this value is always little-endian).

Tested with the English version from GOG, on big-endian PowerPC and little-endian arm64.

@bluegr
Copy link
Member

@bluegr bluegr commented May 10, 2022

Nice catch, thanks! Merging

@bluegr bluegr merged commit 02da6e2 into scummvm:master May 10, 2022
8 checks passed
@dwatteau dwatteau deleted the fix/prince-big-endian-location-offset branch May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants