Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TWINE: Add detection for DotEmu Android version of LBA1 #3889

Merged
merged 4 commits into from Jun 8, 2022

Conversation

einstein95
Copy link
Contributor

@einstein95 einstein95 commented May 16, 2022

This was available in 2014 via Humble Bundle and is notable as it doesn't use VOX files, instead having split ogg files for the sound effects. I'm marking this as a draft for @mgerhardy. This also adds kPlatformAndroid as required.

I'm not sure as to the proper format for the build date, the ARMv7a .so has LBA/Relentless (Sep 8 2014 / 15:55:03) while the x86 .so has LBA/Relentless (Sep 8 2014 / 15:56:52). I used the date/time from the x86 version converted into the same format the other entries use.

@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented May 16, 2022

Oh, and here's the 7z listing of res/raw/lba.zip
lba.zip.txt

@digitall
Copy link
Member

@digitall digitall commented May 17, 2022

@einstein95 : Looks good. One point, can you split this into two commits. The first to the common code i.e. "COMMON: Add Android to Platform Header" and the second to the add the detection entry to TWINE engine i.e. "TWINE: Add detection for ....".

If you don't know how to do this using "git rebase -i" on your branch to update this PR, I can do it for you (upstream contributors get permissions to do this on PR submissions usually on Github).

@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented May 18, 2022

@digitall done

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented May 19, 2022

Looks good to me

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented May 19, 2022

Added a ticket for the unsupported stuff in this version: https://bugs.scummvm.org/ticket/13492

@mgerhardy mgerhardy marked this pull request as ready for review May 19, 2022
@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented May 19, 2022

@einstein95 can you give this a try if it works? I don't have the files in that directory structure and just would like to be sure before merging this. (if it works we can remove the unstable flag)

@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented May 27, 2022

Apologies for the late response, I gave it a try and found a couple bugs that I've fixed in this commit (ScummVM wouldn't play any sounds, due to it trying to play sounds like EN__000_66; and it would play random voice lines instead of footsteps).

I also made a small change in audio/music.cpp where unlike the rest of the file, this one place was doing _engine->_gameFlags & TF_DOTEMU_ENHANCED instead of _engine->isDotEmuEnhanced()

@mgerhardy
Copy link
Contributor

@mgerhardy mgerhardy commented Jun 2, 2022

@einstein95
Copy link
Contributor Author

@einstein95 einstein95 commented Jun 2, 2022

Full list of games from the Humble Mobile Bundle 8 can be seen on https://support.humblebundle.com/hc/en-us/articles/202999884

@mgerhardy mgerhardy merged commit b527d3d into scummvm:master Jun 8, 2022
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants