New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TWINE: Add detection for DotEmu Android version of LBA1 #3889
Conversation
Oh, and here's the 7z listing of |
@einstein95 : Looks good. One point, can you split this into two commits. The first to the common code i.e. "COMMON: Add Android to Platform Header" and the second to the add the detection entry to TWINE engine i.e. "TWINE: Add detection for ....". If you don't know how to do this using "git rebase -i" on your branch to update this PR, I can do it for you (upstream contributors get permissions to do this on PR submissions usually on Github). |
@digitall done |
Looks good to me |
Added a ticket for the unsupported stuff in this version: https://bugs.scummvm.org/ticket/13492 |
@einstein95 can you give this a try if it works? I don't have the files in that directory structure and just would like to be sure before merging this. (if it works we can remove the unstable flag) |
Apologies for the late response, I gave it a try and found a couple bugs that I've fixed in this commit (ScummVM wouldn't play any sounds, due to it trying to play sounds like I also made a small change in |
Full list of games from the Humble Mobile Bundle 8 can be seen on https://support.humblebundle.com/hc/en-us/articles/202999884 |
This was available in 2014 via Humble Bundle and is notable as it doesn't use VOX files, instead having split ogg files for the sound effects. I'm marking this as a draft for @mgerhardy. This also adds
kPlatformAndroid
as required.I'm not sure as to the proper format for the build date, the ARMv7a .so has
LBA/Relentless (Sep 8 2014 / 15:55:03)
while the x86 .so hasLBA/Relentless (Sep 8 2014 / 15:56:52)
. I used the date/time from the x86 version converted into the same format the other entries use.